Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore : Fixed bug risks #110

Merged
merged 2 commits into from
Feb 19, 2021
Merged

chore : Fixed bug risks #110

merged 2 commits into from
Feb 19, 2021

Conversation

powerexploit
Copy link
Contributor

Description

Hi 馃憢 I ran the DeepSource static analyzer on the forked copy of this repo and found some interesting code quality issues. This PR fixes a few of them.

Summary of Fixes

  • Added .deepsource.toml to fix bug risks
  • Consider merging the comparisons with 'in'

Type of change

  • [鉁擼 Antipattern
  • New feature (non-breaking change which adds functionality)

Checklist:

  • [鉁擼 My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

- Added .deepsource.toml to fix bug risk
- Consider merging these comparisons with in
@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #110 (5201df8) into master (a759151) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
+ Coverage   92.31%   92.33%   +0.01%     
==========================================
  Files          17       18       +1     
  Lines         651      652       +1     
==========================================
+ Hits          601      602       +1     
  Misses         50       50              
Flag Coverage 螖
unittests 92.33% <酶> (+0.01%) 猬嗭笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
pyrovision/__init__.py 100.00% <0.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update a759151...5201df8. Read the comment docs.

@powerexploit powerexploit marked this pull request as ready for review February 19, 2021 07:07
@frgfm frgfm self-assigned this Feb 19, 2021
Copy link
Member

@frgfm frgfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, thank you for the PR!
I agree on the modifications for the script but we don't plan on integrating deepsource so far. Consequently, would you mind removing the .toml from the PR please?

@powerexploit
Copy link
Contributor Author

Hi there, thank you for the PR!
I agree on the modifications for the script but we don't plan on integrating deepsource so far. Consequently, would you mind removing the .toml from the PR please?

OK @frgfm I am removing the .toml file.

Copy link
Member

@frgfm frgfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the edit!

@frgfm frgfm added the type: enhancement New feature or request label Feb 19, 2021
@frgfm frgfm added this to the 0.1.2 milestone Feb 19, 2021
@frgfm frgfm merged commit 92e0742 into pyronear:master Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: scripts type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants