Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Added encoding in headers #55

Merged
merged 5 commits into from
Apr 20, 2020
Merged

style: Added encoding in headers #55

merged 5 commits into from
Apr 20, 2020

Conversation

frgfm
Copy link
Member

@frgfm frgfm commented Apr 19, 2020

This PR aims at:

  • adding utf8 encoding when it was missing in header to avoid issues
  • switched to Python 3 class definitions style
  • switched from absolute to relative import when it was not needed (absolute could use existing package installation even if they do not share the same codebase)

@frgfm frgfm added type: enhancement New feature or request module: datasets Related to datasets labels Apr 19, 2020
@frgfm frgfm added this to the 0.1.1 milestone Apr 19, 2020
@frgfm frgfm self-assigned this Apr 19, 2020
@codecov
Copy link

codecov bot commented Apr 19, 2020

Codecov Report

Merging #55 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #55   +/-   ##
=======================================
  Coverage   83.80%   83.80%           
=======================================
  Files          18       18           
  Lines         704      704           
=======================================
  Hits          590      590           
  Misses        114      114           
Impacted Files Coverage Δ
pyronear/datasets/openfire.py 89.47% <ø> (ø)
pyronear/datasets/utils.py 91.66% <ø> (ø)
pyronear/datasets/wildfire/fire_labeler.py 100.00% <ø> (ø)
pyronear/datasets/wildfire/split_strategy.py 96.77% <ø> (ø)
pyronear/models/densenet.py 58.53% <ø> (ø)
pyronear/models/mobilenet.py 63.63% <ø> (ø)
pyronear/models/resnet.py 82.60% <ø> (ø)
pyronear/models/utils.py 98.18% <ø> (ø)
pyronear/nn/functional.py 100.00% <ø> (ø)
pyronear/nn/modules/pooling.py 90.90% <ø> (ø)
... and 1 more

Copy link
Contributor

@x0s x0s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Quickly:

  • Class definition are already new-style
  • The files concerned in this PR are not intended to be used as scripts
  • Okay for relative imports

pyronear/datasets/wildfire/fire_labeler.py Outdated Show resolved Hide resolved
pyronear/datasets/wildfire/wildfire.py Outdated Show resolved Hide resolved
pyronear/datasets/wildfire/fire_labeler.py Outdated Show resolved Hide resolved
@frgfm
Copy link
Member Author

frgfm commented Apr 20, 2020

Thanks for the PR. Quickly:

  • Class definition are already new-style
  • The files concerned in this PR are not intended to be used as scripts
  • Okay for relative imports

Thanks for the review, just made the suggested modifications!

@frgfm frgfm requested a review from x0s April 20, 2020 10:08
@frgfm frgfm merged commit 81d346f into master Apr 20, 2020
@frgfm frgfm deleted the encoding-header branch April 20, 2020 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: datasets Related to datasets type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants