Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project setup documentation to clarify virtualenvwrapper init (fix #70) #71

Merged
merged 1 commit into from
Jun 2, 2020

Conversation

x0s
Copy link
Contributor

@x0s x0s commented May 26, 2020

This PR aims at updating the documentation to clarify environment setup and avoid python 2/3 conflict. Therefore it resolves #70

@x0s x0s added this to In progress in PyroNear kanban via automation May 26, 2020
@x0s x0s added the topic: documentation Improvements or additions to documentation label May 26, 2020
@x0s x0s changed the title Update project setup documentation to fix #70 Update project setup documentation to clarify virtualenvwrapper init (fix #70) May 26, 2020
@x0s
Copy link
Contributor Author

x0s commented May 26, 2020

Hi @frgfm , any idea why the checks are failing and still using circle ci ?

@frgfm
Copy link
Member

frgfm commented May 26, 2020

Regarding CircleCI, as some PRs were still pending when CI was changed, I left the webhook while they are not merged. For the checks, it's strange, I'll try something in another PR to address this while adapting your suggestions from #68!

@x0s x0s added the topic: build Related to build and installation label May 27, 2020
@x0s x0s requested a review from Akilditu May 28, 2020 08:30
@x0s x0s self-assigned this May 28, 2020
@frgfm
Copy link
Member

frgfm commented Jun 1, 2020

Same thing here, I think you just need to make any commit to trigger the workflows :)

@x0s
Copy link
Contributor Author

x0s commented Jun 2, 2020

@frgfm: Could you see any way the tests can fail with such changes in the code base so you are asking again to write fake commits ?

Those for migrated in a hurry from circleci to workflows may take their responsability in this regard. IMO, asking others to fiddle with their PRs is not a good way to maintain the repository.

@frgfm
Copy link
Member

frgfm commented Jun 2, 2020

@frgfm: Could you see any way the tests can fail with such changes in the code base so you are asking again to write fake commits ?

Those for migrated in a hurry from circleci to workflows may take their responsability in this regard. IMO, asking others to fiddle with their PRs is not a good way to maintain the repository.

Not at all, I'm happy reviewing this. You specifically asked me why the CI would fail, I'm suggesting a way to handle this. But with this change, I agree that untriggered tests are not a big issue.

PyroNear kanban automation moved this from In progress to Reviewer approved Jun 2, 2020
Copy link
Member

@frgfm frgfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@x0s x0s merged commit 679f7ad into pyronear:master Jun 2, 2020
PyroNear kanban automation moved this from Reviewer approved to Done Jun 2, 2020
@x0s x0s deleted the fix-virtualenvwrapper-failed-install branch June 3, 2020 13:59
Akilditu pushed a commit to Akilditu/seb_pyro-vision that referenced this pull request Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: build Related to build and installation topic: documentation Improvements or additions to documentation
Projects
Development

Successfully merging this pull request may close these issues.

Bug: "No module named virtualenvwrapper"
2 participants