-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update project setup documentation to clarify virtualenvwrapper init (fix #70) #71
Conversation
Hi @frgfm , any idea why the checks are failing and still using circle ci ? |
Regarding CircleCI, as some PRs were still pending when CI was changed, I left the webhook while they are not merged. For the checks, it's strange, I'll try something in another PR to address this while adapting your suggestions from #68! |
Same thing here, I think you just need to make any commit to trigger the workflows :) |
@frgfm: Could you see any way the tests can fail with such changes in the code base so you are asking again to write fake commits ? Those for migrated in a hurry from circleci to workflows may take their responsability in this regard. IMO, asking others to fiddle with their PRs is not a good way to maintain the repository. |
Not at all, I'm happy reviewing this. You specifically asked me why the CI would fail, I'm suggesting a way to handle this. But with this change, I agree that untriggered tests are not a big issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
This PR aims at updating the documentation to clarify environment setup and avoid python 2/3 conflict. Therefore it resolves #70