Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Ensure squashed merged PR triggers workflow #74

Merged
merged 3 commits into from
Jun 3, 2020
Merged

Conversation

frgfm
Copy link
Member

@frgfm frgfm commented May 28, 2020

Currently, PR trigger the main workflow, but once the commits are squash-merged into master, the workflow do not run again.

This PR enforces workflow trigger on squash merged commits into master.

@frgfm frgfm added type: enhancement New feature or request module: ci labels May 28, 2020
@frgfm frgfm added this to the 0.1.1 milestone May 28, 2020
@frgfm frgfm self-assigned this May 28, 2020
@codecov
Copy link

codecov bot commented May 28, 2020

Codecov Report

Merging #74 into master will decrease coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
- Coverage   85.32%   85.07%   -0.26%     
==========================================
  Files          20       20              
  Lines         777      777              
==========================================
- Hits          663      661       -2     
- Misses        114      116       +2     
Impacted Files Coverage Δ
pyronear/utils/collect_env.py 70.66% <0.00%> (-1.34%) ⬇️
pyronear/datasets/utils.py 93.05% <0.00%> (+1.38%) ⬆️

@frgfm frgfm requested a review from x0s May 28, 2020 14:10
@frgfm
Copy link
Member Author

frgfm commented May 28, 2020

@blenzi you might want to do the same thing for the repos you recently set up CI on ;)

Copy link
Contributor

@blenzi blenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blenzi you might want to do the same thing for the repos you recently set up CI on ;)

Thanks @frgfm! This is already the case for VideoSplitter and VideoAnnotator

@frgfm frgfm merged commit 3a37e57 into master Jun 3, 2020
@frgfm frgfm deleted the workflow-trigger branch June 3, 2020 07:38
Akilditu pushed a commit to Akilditu/seb_pyro-vision that referenced this pull request Jun 3, 2020
* chore: Ensure squashed merged PR triggers workflow

* chore: Workflow push triggers are limited to master branch

* chore: Fixed workflow config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants