refactor: Refactored pyrovision.datasets module #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frgfm
added
type: enhancement
|
The link validity check failure isn't related, and will be fixed once #96 is merged. Regarding the unittest failure, I have seen this one of other PRs before, I'm not sure about its origin. It's seems like a random edge case because it doesn't always pop, and I'm not able to reproduce it locally. |
MateoLostanlen
approved these changes
Feb 6, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #94, this PR introduces the following modifications:
Once this PR is merged (which keeps every single class/function), we'll need to reassess which part are relevant to the library I think (fire labeler might not be really relevant here, perhaps in a repo dedicated to data labelling?)
Any feedback is welcome!