Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename output dir #22

Closed
eh-am opened this issue Jan 31, 2023 · 0 comments · Fixed by #24
Closed

rename output dir #22

eh-am opened this issue Jan 31, 2023 · 0 comments · Fixed by #24

Comments

@eh-am
Copy link
Collaborator

eh-am commented Jan 31, 2023

since the binary was renamed to pyroscope-ci, it clashes with the default outputDir (

ci/cmd/exec.go

Line 15 in 035cf6b

outputDir := execFlagSet.String("outputDir", "pyroscope-ci", "where the generated profiles will be saved to. only available if --no-upload is set")
), yielding a non obvious error to end users: pyroscope-ci mkdir pyroscope-ci not a directory`
@eh-am eh-am mentioned this issue Jan 31, 2023
Merged
@eh-am eh-am closed this as completed in #24 Jan 31, 2023
eh-am added a commit that referenced this issue Jan 31, 2023
@eh-am
fix: change default output-dir (#24)
84afa2d 
Closes #22
Considering this a bugfix since it simply shouldn't work out of the box
(since it conflicts with the binary name), althought it's technically a
breaking change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: change default output-dir pyroscope-io/ci
1 participant
@eh-am