feat: allow uploading and exporting at the same time #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eh-am
pushed a commit
that referenced
this pull request
Feb 2, 2023
🤖 I have created a release *beep* *boop* --- ## [1.2.0](v1.1.0...v1.2.0) (2023-02-02) ### Features * allow uploading and exporting at the same time ([#26](#26)) ([4325d2a](4325d2a)) ### Bug Fixes * change default output-dir ([#24](#24)) ([84afa2d](84afa2d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now one can both export data to a local dir and upload to a remote server. This allows taking the output and uploading to flamegraph.com using https://github.com/pyroscope-io/flamegraph.com-github-action
This change is a slightly breaking one, but I believe no one should be relying on the previous behaviour (where
--noUploadalso makes it write to a local dir).