Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: upload to flamegraph.com #36

Merged
merged 8 commits into from
Mar 2, 2023

Conversation

eh-am
Copy link
Collaborator

@eh-am eh-am commented Feb 27, 2023

Add another flag --uploadToPublicAPI that uploads to flamegraph.com

Example:

pyroscope-ci exec --uploadToPublicAPI --uploadToCloud=false -- go test ./... -count=1                                                             
ok      example/fib     16.034s                                                                                                                    
INFO[0017] Profiles have been uploaded to a public API:                                                                                            
INFO[0017]      myapp.alloc_space       https://flamegraph.com/share/e5c21989-b761-11ed-aad5-e25423ad2a59                                          
INFO[0017]      myapp.cpu       https://flamegraph.com/share/e5c1b256-b761-11ed-aad5-e25423ad2a59                                                  
INFO[0017]      myapp.goroutines        https://flamegraph.com/share/e5c1e0f1-b761-11ed-aad5-e25423ad2a59                                          
INFO[0017]      myapp.inuse_space       https://flamegraph.com/share/e5c1e914-b761-11ed-aad5-e25423ad2a59                                          
INFO[0017]      myapp.alloc_objects     https://flamegraph.com/share/e5c1a0b3-b761-11ed-aad5-e25423ad2a59                                          
INFO[0017]      myapp.inuse_objects     https://flamegraph.com/share/e5c218a0-b761-11ed-aad5-e25423ad2a59 

Also rename other flags:

--export   -> --exportLocally
--noUpload -> --uploadToCloud

@eh-am eh-am marked this pull request as ready for review February 28, 2023 12:29
@Rperry2174
Copy link
Member

why doees it have both --uploadToPublicAPI and also --noUpload don't those contradict each other?

@eh-am
Copy link
Collaborator Author

eh-am commented Feb 28, 2023

--noUpload refers to uploading to the pyroscope cloud, it's enabled by default since that's the default case. it's unfortunate naming because it was assumed upload could >only< be to pyroscope cloud, if only we knew there would be other upload targets i would've called it differently :(

@Rperry2174
Copy link
Member

Rperry2174 commented Mar 1, 2023

Even though it's a breaking change I think we should:

  1. Get rid of --noUpload (in favor of --uploadToCloud and --uploadToPublicAPI
  2. rename --export to --exportLocally

That way everything is very explicit

@eh-am eh-am changed the title feat: upload to flamegraph.com feat!: upload to flamegraph.com Mar 2, 2023
@eh-am eh-am merged commit a459bbd into main Mar 2, 2023
@eh-am eh-am deleted the feat/allow-uploading-to-flamegraph-dot-com branch March 2, 2023 10:54
eh-am pushed a commit that referenced this pull request Mar 3, 2023
🤖 I have created a release *beep* *boop*
---


## [2.0.0](v1.3.0...v2.0.0)
(2023-03-02)


### ⚠ BREAKING CHANGES

* upload to flamegraph.com
([#36](#36))

### Features

* upload to flamegraph.com
([#36](#36))
([a459bbd](a459bbd))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants