Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implements support for environment variable substitutions in config file #1283

Merged
merged 4 commits into from
Jul 25, 2022

Conversation

petethepig
Copy link
Member

@petethepig petethepig commented Jul 18, 2022

Still need to handle $1:$2 case properly, I have an idea for it, just need to implement it.

@petethepig petethepig changed the title feat: implements support for env substitutions in config file feat: implements support for environment variable substitutions in config file Jul 18, 2022
@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #1283 (349aea5) into main (9740c54) will decrease coverage by 1.33%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1283      +/-   ##
==========================================
- Coverage   69.85%   68.52%   -1.32%     
==========================================
  Files         111      112       +1     
  Lines        3628     3713      +85     
  Branches      971      842     -129     
==========================================
+ Hits         2534     2544      +10     
- Misses       1091     1167      +76     
+ Partials        3        2       -1     
Impacted Files Coverage Δ
...ages/pyroscope-flamegraph/src/FlameGraph/decode.ts 56.76% <0.00%> (-33.24%) ⬇️
webapp/javascript/ui/Box.tsx 60.00% <0.00%> (ø)
packages/pyroscope-flamegraph/src/index.tsx 100.00% <0.00%> (ø)
...raph/src/FlameGraph/FlameGraphComponent/murmur3.ts 100.00% <0.00%> (ø)
...yroscope-flamegraph/src/convert/diffTwoProfiles.ts 6.25% <0.00%> (ø)
...megraph/src/convert/convertJaegerTraceToProfile.ts 16.33% <0.00%> (+1.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9740c54...349aea5. Read the comment docs.

@eh-am
Copy link
Collaborator

eh-am commented Jul 18, 2022

you may be interested in https://github.com/pyroscope-io/pyroscope/blob/main/pkg/cli/server.go#L372 and https://github.com/pyroscope-io/pyroscope/blob/main/pkg/cli/server.go#L393

@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 399.01 KB (0%) 8 s (0%) 3 s (+5.17% 🔺) 11 s
webapp/public/assets/app.css 12.93 KB (0%) 259 ms (0%) 0 ms (+100% 🔺) 259 ms
webapp/public/assets/styles.css 9.8 KB (0%) 197 ms (0%) 0 ms (+100% 🔺) 197 ms
packages/pyroscope-flamegraph/dist/index.js 89.24 KB (0%) 1.8 s (0%) 902 ms (-28.13% 🔽) 2.7 s
packages/pyroscope-flamegraph/dist/index.node.js 80.62 KB (0%) 1.7 s (0%) 435 ms (+5.56% 🔺) 2.1 s
packages/pyroscope-flamegraph/dist/index.css 5.84 KB (0%) 117 ms (0%) 0 ms (+100% 🔺) 117 ms

@petethepig petethepig requested review from kolesnikovae and eh-am and removed request for kolesnikovae July 18, 2022 23:18
@petethepig
Copy link
Member Author

@eh-am I am very much indeed! I should definitely add it there otherwise it won't work for remote write 🤦🏼

@petethepig petethepig merged commit e72c847 into main Jul 25, 2022
@petethepig petethepig deleted the config-env-subs branch July 25, 2022 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants