Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show functions % of total [units] in Table #1288

Merged
merged 11 commits into from
Jul 25, 2022
Merged

Conversation

dogfrogfog
Copy link
Contributor

@dogfrogfog dogfrogfog commented Jul 19, 2022

#1281

Tooltip can be reused

@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #1288 (4586939) into main (94bee2c) will decrease coverage by 1.49%.
The diff coverage is 76.00%.

@@            Coverage Diff             @@
##             main    #1288      +/-   ##
==========================================
- Coverage   69.85%   68.37%   -1.48%     
==========================================
  Files         111      115       +4     
  Lines        3628     3847     +219     
  Branches      971      886      -85     
==========================================
+ Hits         2534     2630      +96     
- Misses       1091     1215     +124     
+ Partials        3        2       -1     
Impacted Files Coverage Δ
...roscope-flamegraph/src/Tooltip/Tooltip.module.scss 61.54% <50.00%> (ø)
.../pyroscope-flamegraph/src/Tooltip/TableTooltip.tsx 58.14% <58.14%> (ø)
...pyroscope-flamegraph/src/Tooltip/LeftClickIcon.tsx 71.43% <71.43%> (ø)
...scope-flamegraph/src/Tooltip/FlamegraphTooltip.tsx 76.39% <76.39%> (ø)
...kages/pyroscope-flamegraph/src/Tooltip/Tooltip.tsx 82.76% <82.76%> (ø)
...ackages/pyroscope-flamegraph/src/ProfilerTable.tsx 66.44% <83.34%> (+0.84%) ⬆️
...graph/src/FlameGraph/FlameGraphComponent/index.tsx 83.08% <100.00%> (ø)
...yroscope-flamegraph/src/Tooltip/RightClickIcon.tsx 100.00% <100.00%> (ø)
...ages/pyroscope-flamegraph/src/FlameGraph/decode.ts 56.76% <0.00%> (-33.24%) ⬇️
webapp/javascript/ui/Box.tsx 60.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94bee2c...4586939. Read the comment docs.

@dogfrogfog
Copy link
Contributor Author

2022-07-19.18.38.07.mov

@Rperry2174
Copy link
Contributor

/create-server

@dogfrogfog
Copy link
Contributor Author

/create-server

@github-actions
Copy link
Contributor

github-actions bot commented Jul 20, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 399.73 KB (+0.18% 🔺) 8 s (+0.18% 🔺) 3 s (-32.7% 🔽) 11 s
webapp/public/assets/app.css 12.9 KB (-0.25% 🔽) 259 ms (-0.25% 🔽) 0 ms (+100% 🔺) 259 ms
webapp/public/assets/styles.css 9.8 KB (0%) 197 ms (0%) 0 ms (+100% 🔺) 197 ms
packages/pyroscope-flamegraph/dist/index.js 89.91 KB (+0.76% 🔺) 1.8 s (+0.76% 🔺) 1.8 s (+10.43% 🔺) 3.6 s
packages/pyroscope-flamegraph/dist/index.node.js 81.28 KB (+0.82% 🔺) 1.7 s (+0.82% 🔺) 777 ms (+8.45% 🔺) 2.5 s
packages/pyroscope-flamegraph/dist/index.css 5.81 KB (-0.46% 🔽) 117 ms (-0.46% 🔽) 0 ms (+100% 🔺) 117 ms

@dogfrogfog
Copy link
Contributor Author

/create-server

@Rperry2174
Copy link
Contributor

/create-server

@Rperry2174
Copy link
Contributor

looks great! one comment which is can we remove this extra tooltip now that we have the fancier one?
image

@dogfrogfog
Copy link
Contributor Author

/create-server

@dogfrogfog dogfrogfog marked this pull request as ready for review July 21, 2022 13:11
@Rperry2174
Copy link
Contributor

/create-server

@Rperry2174 Rperry2174 merged commit 6c71195 into main Jul 25, 2022
@Rperry2174 Rperry2174 deleted the feature/show-percent branch July 25, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants