-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create tag-explorer page for analyzing tag breakdowns #1293
Conversation
size-limit report 📦
|
Codecov Report
@@ Coverage Diff @@
## main #1293 +/- ##
==========================================
- Coverage 68.52% 67.58% -0.94%
==========================================
Files 112 119 +7
Lines 3713 3960 +247
Branches 842 906 +64
==========================================
+ Hits 2544 2676 +132
- Misses 1167 1282 +115
Partials 2 2
Continue to review full report at Codecov.
|
…roscope into feature/app-explore-page
2022-07-22.21.13.19.mov |
/create-server |
two more request -- currently when you select the Also lets call it "Tag explorer" in the sidebar and nest it first under the "continuous" section |
/create-server |
Looks great... Although another idea here :) Can we also make it so that if no tag is selected, then we highlight the "group by" dropdown with this orange border: I think that will make it clearer to the user that they should start by selecting a tag in that dropdown. Once a tag is selected then the dropdown should look normal Also lets replace the icon with a magnifying glass icon like this one: https://fontawesome.com/icons/magnifying-glass-chart?s=solid (if we can get with our version -- otherwise just use the next closest icon that we have access to) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! thanks @dogfrogfog
#1282