Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make /apps respect remoteRead #1645

Merged
merged 1 commit into from
Oct 27, 2022
Merged

Conversation

eh-am
Copy link
Collaborator

@eh-am eh-am commented Oct 27, 2022

not an optimal solution but a quick fix for demo-dev to work

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 445.85 KB (0%) 9 s (0%) 2.8 s (-13.41% 🔽) 11.7 s
webapp/public/assets/app.css 17.95 KB (0%) 359 ms (0%) 0 ms (+100% 🔺) 359 ms
webapp/public/assets/styles.css 9.52 KB (0%) 191 ms (0%) 0 ms (+100% 🔺) 191 ms
packages/pyroscope-flamegraph/dist/index.js 92.19 KB (0%) 1.9 s (0%) 1.4 s (+50.09% 🔺) 3.3 s
packages/pyroscope-flamegraph/dist/index.node.js 92.08 KB (0%) 1.9 s (0%) 520 ms (+17.67% 🔺) 2.4 s
packages/pyroscope-flamegraph/dist/index.css 7.4 KB (0%) 148 ms (0%) 0 ms (+100% 🔺) 148 ms

@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Base: 66.22% // Head: 66.22% // No change to project coverage 👍

Coverage data is based on head (5a88f47) compared to base (b3ea639).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1645   +/-   ##
=======================================
  Coverage   66.22%   66.22%           
=======================================
  Files         147      147           
  Lines        4997     4997           
  Branches     1145     1145           
=======================================
  Hits         3309     3309           
  Misses       1683     1683           
  Partials        5        5           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@eh-am eh-am marked this pull request as ready for review October 27, 2022 15:45
@eh-am
Copy link
Collaborator Author

eh-am commented Oct 27, 2022

/create-server

@eh-am eh-am merged commit 3e85b17 into main Oct 27, 2022
@eh-am eh-am deleted the fix/remote-write-applications branch October 27, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant