Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in xmlrpc-c-advanced-2954/common.mk #119

Open
zetafunction opened this issue Jan 13, 2019 · 0 comments
Open

Typo in xmlrpc-c-advanced-2954/common.mk #119

zetafunction opened this issue Jan 13, 2019 · 0 comments

Comments

@zetafunction
Copy link

It looks like this is pulled via a source tarball, so I'm not sure how to send a pull request. common.mk defines LDFLAGS_FOR_BUILD_ALL, but gennmtab's Makefile expects it to be named LDFLAGS_ALL_FOR_BUILD. This typo prevents linker flags added in LADD from being used when building gennmtab.

Simple patch:

--- common.mk.orig      2019-01-13 09:46:36.483669731 -0800
+++ common.mk   2019-01-13 09:46:46.355988659 -0800
@@ -96,7 +96,7 @@
 
 LDFLAGS_ALL = $(LDFLAGS_PTHREAD) $(LDFLAGS_PERSONAL) $(LDFLAGS)
 
-LDFLAGS_FOR_BUILD_ALL = \
+LDFLAGS_ALL_FOR_BUILD = \
   $(LDFLAGS_PTHREAD) $(LDFLAGS_PERSONAL) $(LDFLAGS_FOR_BUILD)
 
 ##############################################################################
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant