New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Path::strip_prefix instead of textual replacement of base path #35

Closed

Boscop opened this issue Jul 23, 2018 · 0 comments

Boscop commented Jul 23, 2018

It'd be more idiomatic to use Path::strip_prefix here:

https://github.com/pyros2097/rust-embed/blob/de355d14b4edd86a5f8b33503344772345fadacc/src/lib.rs#L54

pyrossh closed this as completed in

c41fdea

pyrossh pushed a commit that referenced this issue


          use strip_prefix closes #35

3b580df

pyrossh pushed a commit that referenced this issue


          use strip_prefix closes #35

3e64013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment