-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error after updating to 5.0.0 #74
Comments
@pyros2097 I also see this on my project. We should probably re-export the utils crate in the main crate, then use it that way. |
However, surprisingly my Dependabot PR didn't fail the build? pi-hole/api#190 |
My Dependabot PR did fail with both |
I wonder how the tests are passing then. This is such a weird case. I almost thought I published the crate without adding the |
I'm lost with this one. I tried adding it to the lib.rs or rust-embed and still no luck. the release builds are working though. Don't know why just the debug builds are breaking. |
Here is an isolated example that you can get to compile in some ways. |
Ah, that's probably the difference. My CI compiles in release mode, whereas @rushsteve1's CI probably compiles it in debug mode at some point. |
The utils crate is re-exported from the main crate for use in debug builds. Debug builds are compiled by the macro to use certain functions from the utils crate. This is different than in release mode, where the macro itself uses the functions and does not require them at runtime. When the debug code tries to import the utils crate, it fails because it is not an explicit dependency in Cargo.toml. Fixes #74 Signed-off-by: Mcat12 <newtoncat12@yahoo.com>
The utils crate is re-exported from the main crate for use in debug builds. Debug builds are compiled by the macro to use certain functions from the utils crate. This is different than in release mode, where the macro itself uses the functions and does not require them at runtime. When the debug code tries to import the utils crate, it fails because it is not an explicit dependency in Cargo.toml. Fixes #74 Signed-off-by: Mcat12 <newtoncat12@yahoo.com>
The utils crate is re-exported from the main crate for use in debug builds. Debug builds are compiled by the macro to use certain functions from the utils crate. This is different than in release mode, where the macro itself uses the functions and does not require them at runtime. When the debug code tries to import the utils crate, it fails because it is not an explicit dependency in Cargo.toml. Fixes #74 Signed-off-by: Mcat12 <newtoncat12@yahoo.com>
After updating to verision 5.0.0 I get the following error, in multiple different codebases
The error is fixed by adding the following to
Cargo.toml
so it seems like something is missing a dependency.rustc 1.36.0 (a53f9df32 2019-07-03)
cargo 1.36.0 (c4fcfb725 2019-05-15)
The text was updated successfully, but these errors were encountered: