Use standard logging in debug mode #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In debug mode, the `quote!`'d code is not guarrenteed to have access to the `log` macros, and in some cases the macros may be completely different (Rocket has its own `error!` macro). Change `info` to `println` and `error` to `eprintln`. Signed-off-by: Mcat12 <newtoncat12@yahoo.com>
|
Ok. Seems good. LGTM. |
pyrossh
pushed a commit
that referenced
this pull request
Aug 24, 2021
Use standard logging in debug mode
pyrossh
pushed a commit
that referenced
this pull request
Aug 24, 2021
Use standard logging in debug mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In debug mode, the
quote!'d code is not guarrenteed to have access to thelogmacros, and in some cases the macros may be completely different (Rocket has its ownerror!macro).Solution: change
infotoprintlnanderrortoeprintln.Note: The build is broken because the Cargo.lock file is out of date, but #11 fixes that.