Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add axum-spa example #184

Merged
merged 9 commits into from
Aug 28, 2022
Merged

add axum-spa example #184

merged 9 commits into from
Aug 28, 2022

Conversation

frederikhors
Copy link
Contributor

@frederikhors frederikhors commented Aug 24, 2022 •
edited
Loading

I hope this example can be added.

I will also ask axum the same thing.

Thanks for your help.

Closes #183.

This was referenced Aug 24, 2022
Closed
Closed
AzureMarker
AzureMarker requested changes Aug 26, 2022
View reviewed changes
Copy link
Collaborator

@AzureMarker AzureMarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks pretty good! Just need to fix up the file organization, and I have a few nits.

examples/axum-spa/Cargo.toml Outdated Show resolved Hide resolved
examples/axum-spa/src/main.rs Outdated Show resolved Hide resolved
examples/axum-spa/src/main.rs Outdated Show resolved Hide resolved
examples/axum-spa/src/main.rs Outdated Show resolved Hide resolved
AzureMarker
AzureMarker requested changes Aug 27, 2022
View reviewed changes
examples/axum-spa/src/main.rs Outdated Show resolved Hide resolved
examples/axum-spa/src/main.rs Outdated Show resolved Hide resolved
@AzureMarker AzureMarker merged commit ae15c13 into pyrossh:master Aug 28, 2022
@frederikhors frederikhors deleted the add-axum-spa-example branch August 29, 2022 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyrossh pyrossh pyrossh left review comments

@AzureMarker AzureMarker AzureMarker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Single page application (SPA) example
3 participants
@frederikhors @pyrossh @AzureMarker