Fixing bug in filenames with dashes #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filenames with dasesh would not create valid rust identifiers since they cannot include dashes in the identifier. Additionally added attribute to turn off unused code warnings and moved the #[allow(non_upper_case_globals)] to a global attribute
|
Thanks for the PR. Yeah this solves the specific case for dash maybe there is a lib like lodash for rust which will remove all special characters like snakeCaseify or camelCaseify. |
|
LGTM |
pyrossh
pushed a commit
that referenced
this pull request
Aug 24, 2021
Fixing bug in filenames with dashes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filenames with dashes would not create valid rust identifiers since they
cannot include dashes in the identifier.
Additionally added attribute to turn off unused code warnings and moved
the #[allow(non_upper_case_globals)] to a global attribute