Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid vector allocation #40

Merged
merged 3 commits into from
Oct 11, 2018
Merged

Avoid vector allocation #40

merged 3 commits into from
Oct 11, 2018

Conversation

vemoo
Copy link
Contributor

@vemoo vemoo commented Oct 9, 2018

By returning Option<impl AsRef[u8]>.
Fixes #26.
Is a breaking change.

@pyrossh
Copy link
Owner

pyrossh commented Oct 10, 2018

@vemoo Great work. Would you mind updating the readme and also bump up the version to 4.0.0.
Will merge it after that and publish the latest version.

@pyrossh pyrossh self-requested a review October 10, 2018 08:18
@vemoo
Copy link
Contributor Author

vemoo commented Oct 10, 2018

Done.

@pyrossh pyrossh merged commit c4b5672 into pyrossh:master Oct 11, 2018
pyrossh pushed a commit that referenced this pull request Aug 24, 2021
Avoid vector allocation
pyrossh pushed a commit that referenced this pull request Aug 24, 2021
Avoid vector allocation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants