Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use subprocess to adapt in serial #71

Closed
jwallwork23 opened this issue Jan 25, 2024 · 1 comment · Fixed by #72
Closed

Use subprocess to adapt in serial #71

jwallwork23 opened this issue Jan 25, 2024 · 1 comment · Fixed by #72
Assignees
@jwallwork23
Labels
enhancement New feature or request PRIORITY We should address this ASAP
Milestone
Version 1

Comments

@jwallwork23
Copy link
Contributor

ParMmg doesn't support parallel adaptation in 2D. However, solving 2Ds PDEs in parallel is a standard activity of Firedrake. We should use Python subprocess to enable serial adaptation during a parallel run.
@jwallwork23 jwallwork23 added the enhancement New feature or request label Jan 25, 2024
@jwallwork23 jwallwork23 added this to the Version 1 milestone Jan 25, 2024
@jwallwork23 jwallwork23 self-assigned this Jan 25, 2024
@jwallwork23
Copy link
Contributor Author

See mesh-adaptation/goalie#96.

@jwallwork23 jwallwork23 mentioned this issue Jan 25, 2024
Closed
jwallwork23 added a commit that referenced this issue Jan 26, 2024
@jwallwork23
#71: First draft adapt subproc
87ab9d2
@jwallwork23 jwallwork23 mentioned this issue Jan 26, 2024
Merged
jwallwork23 added a commit that referenced this issue Jan 29, 2024
@jwallwork23
#71: Add new utility file
84fb07f
jwallwork23 added a commit that referenced this issue Feb 15, 2024
@jwallwork23
#71: First draft adapt subproc
8994ce3
jwallwork23 added a commit that referenced this issue Feb 15, 2024
@jwallwork23
#71: Add new utility file
7047b2c
jwallwork23 added a commit that referenced this issue Feb 15, 2024
@jwallwork23
#71: Use serial kwarg in tests
628e274
jwallwork23 added a commit that referenced this issue Feb 15, 2024
@jwallwork23
#71: 'serialise' rather than 'serial'
93bc134
jwallwork23 added a commit that referenced this issue Feb 15, 2024
@jwallwork23
#71: Unit tests for get_venv_path
fc4b7c7
jwallwork23 added a commit that referenced this issue Feb 15, 2024
@jwallwork23
#71: Add save_checkpoint method for MetricBasedAdaptor
5fc0adf
jwallwork23 added a commit that referenced this issue Feb 15, 2024
@jwallwork23
#71: Unit tests for MetricBasedAdaptor.save_checkpoint
75df21e
jwallwork23 added a commit that referenced this issue Feb 15, 2024
@jwallwork23
#71: load_checkpoint method
420aa59
jwallwork23 added a commit that referenced this issue Feb 15, 2024
@jwallwork23
#71: Unit test for load_checkpoint
882c65f
@ddundo ddundo mentioned this issue Feb 16, 2024
Closed
jwallwork23 added a commit that referenced this issue Mar 6, 2024
@jwallwork23
#71: First draft adapt subproc
d71a16d
jwallwork23 added a commit that referenced this issue Mar 6, 2024
@jwallwork23
#71: Add new utility file
8cdd371
jwallwork23 added a commit that referenced this issue Mar 6, 2024
@jwallwork23
#71: Use serial kwarg in tests
b3b22bb
jwallwork23 added a commit that referenced this issue Mar 6, 2024
@jwallwork23
#71: 'serialise' rather than 'serial'
8051fdd
jwallwork23 added a commit that referenced this issue Mar 6, 2024
@jwallwork23
#71: Unit tests for get_venv_path
f39a82a
jwallwork23 added a commit that referenced this issue Mar 6, 2024
@jwallwork23
#71: Add save_checkpoint method for MetricBasedAdaptor
2bca572
jwallwork23 added a commit that referenced this issue Mar 6, 2024
@jwallwork23
#71: Unit tests for MetricBasedAdaptor.save_checkpoint
44b8682
jwallwork23 added a commit that referenced this issue Mar 6, 2024
@jwallwork23
#71: load_checkpoint method
71336da
jwallwork23 added a commit that referenced this issue Mar 6, 2024
@jwallwork23
#71: Unit test for load_checkpoint
4684089
jwallwork23 added a commit that referenced this issue Mar 6, 2024
@jwallwork23
#71: Introduce ANIMATE_CHECKPOINT_DIR
bba87d0
jwallwork23 added a commit that referenced this issue Mar 6, 2024
@jwallwork23
#71: save_mesh does not support name
584b4f0
jwallwork23 added a commit that referenced this issue Mar 6, 2024
@jwallwork23
#71: Functions for handling directories
92b4926
jwallwork23 added a commit that referenced this issue Mar 8, 2024
@jwallwork23
#71: Fix checkpointing tests
18deb01
jwallwork23 added a commit that referenced this issue Mar 8, 2024
@jwallwork23
#71: Tests for saving and loading metric parameters
b48df93
jwallwork23 added a commit that referenced this issue Mar 8, 2024
@jwallwork23
#71: Set ANIMATE_CHECKPOINT_DIR, not ANIMATE_DIR
08963af
jwallwork23 added a commit that referenced this issue Mar 8, 2024
@jwallwork23
#71: Fix barriers
90facc3
jwallwork23 added a commit that referenced this issue Mar 8, 2024
@jwallwork23
#71: Tweak mesh name
61717de
jwallwork23 added a commit that referenced this issue Mar 8, 2024
@jwallwork23
#71: Set name and comm in base class
dab6246
jwallwork23 added a commit that referenced this issue Mar 8, 2024
@jwallwork23
#71: Default comm from mesh
83d8b81
jwallwork23 added a commit that referenced this issue Mar 8, 2024
@jwallwork23
#71: Fix 2D parallel case and test
6ac1114
ddundo added a commit that referenced this issue Mar 8, 2024
@ddundo
#71: Fix naming in checkpointing
7fcce99
jwallwork23 added a commit that referenced this issue Mar 13, 2024
@jwallwork23
#71: Neaten animate path
3c0e1ed
ddundo added a commit that referenced this issue Mar 13, 2024
@ddundo
#71: Add and modify unit tests for custom mesh names
dabb9f6
jwallwork23 added a commit that referenced this issue Mar 13, 2024
@jwallwork23
#71: Fix path
161a667
ddundo added a commit that referenced this issue Mar 13, 2024
@ddundo
#71: Fix name during loading
b7e4617
jwallwork23 added a commit that referenced this issue Mar 14, 2024
@jwallwork23
#71: Bizarre fix for ranks other than 0
0d94e89
jwallwork23 added a commit that referenced this issue Mar 14, 2024
@jwallwork23
#71: Increase sleep time to 1e-3
b0f0b99
jwallwork23 added a commit that referenced this issue Mar 15, 2024
@jwallwork23
#71: Reformat; attempt to reduce sleep time
3e519a2
jwallwork23 added a commit that referenced this issue Mar 15, 2024
@jwallwork23
#71: Turn all tests back on
3f152e5
jwallwork23 added a commit that referenced this issue Mar 18, 2024
@jwallwork23
#71: Fix comm comment
67c1d52
ddundo added a commit that referenced this issue May 4, 2024
@ddundo
#71: Remove get_checkpoint_dir from utility
abcae15
ddundo added a commit that referenced this issue May 4, 2024
@ddundo
#71: Tidy up and add barrier back
02ac527
ddundo added a commit that referenced this issue May 4, 2024
@ddundo
#71: Add get_checkpoint_dir to checkpointing and rename filename argu…
706c2b4 
…ment
ddundo added a commit that referenced this issue May 4, 2024
@ddundo
#71: Add test for loading from a nonexistant checkpoint file
346e812
ddundo added a commit that referenced this issue May 4, 2024
@ddundo
#71: Remove old tests
a33cc27
ddundo added a commit that referenced this issue May 6, 2024
@ddundo
#71: Create .checkpoints dir
f181d2b
ddundo added a commit that referenced this issue May 6, 2024
@ddundo
#71: Create .checkpoints dir
e8b2d5b
ddundo added a commit that referenced this issue May 10, 2024
@ddundo
#71: Clearer 'serialise' argument
6e1fc55
ddundo added a commit that referenced this issue May 10, 2024
@ddundo
#71: Correct docstring
259a6de
ddundo added a commit that referenced this issue May 10, 2024
@ddundo
#71: Delete temp checkpoint dirs created during testing
1d82859
jwallwork23 added a commit that referenced this issue May 10, 2024
@jwallwork23 @ddundo
Option for adapting in serial (#72)
9fc2382 
Closes #71.

---------

Co-authored-by: ddundo <davord.no@gmail.com>
Co-authored-by: Davor Dundovic <33790330+ddundo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jwallwork23 jwallwork23

Labels
enhancement New feature or request PRIORITY We should address this ASAP
Projects
Mesh Adaptation development board
Status: Done
Milestone
Version 1
Development

Successfully merging a pull request may close this issue.

Option for adapting in serial mesh-adaptation/animate
1 participant
@jwallwork23