Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make back button go back to "Objectives" page when viewing an SLO #590

Closed
asubiotto opened this issue Jan 24, 2023 · 1 comment
Closed

Make back button go back to "Objectives" page when viewing an SLO #590

asubiotto opened this issue Jan 24, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@asubiotto
Copy link
Contributor

When I'm playing around with an SLO (e.g. changing error budget time window, scrolling down etc...) and then press the back button on my browser, I expect to be taken back to the "Objectives" page to see all SLOs. What is happening right now is that all scroll movements and time window changes are cycled through in reverse order before going back to the "Objectives" page. I wonder if that's intentional.
@metalmatze
Copy link
Member

This isn't ideal for sure.
We should probably move back to setting the timestamps relatively. As in now-1h and now rather than updating the timestamps e.g. every 10s...

The underlying idea was to have timestamps in the URL to make sharing a SLO with the specific time ranges possible. However, the specific timestamps should probably only be set if one selects the specific range in the graphs...

@metalmatze metalmatze added the bug Something isn't working label Feb 19, 2023
metalmatze added a commit that referenced this issue Feb 19, 2023
@metalmatze
Use text for relative timestamps and numbers for absolute
d7c4c3a 
Using text like `now` and `now-12h` will not spam the browser's history like reported in #590.

However, selecting a specific time range with the cursor in the graphs will now still select the very specific timestamps and store them in the URL.
@metalmatze metalmatze mentioned this issue Feb 19, 2023
Merged
metalmatze added a commit that referenced this issue Feb 20, 2023
@metalmatze
Use text for relative timestamps and numbers for absolute
43a8013 
Using text like `now` and `now-12h` will not spam the browser's history like reported in #590.

However, selecting a specific time range with the cursor in the graphs will now still select the very specific timestamps and store them in the URL.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@metalmatze @asubiotto