Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Alerting spec to propagate labels and annotations #1003

Closed

Conversation

ArthurSens
Copy link
Contributor

@ArthurSens ArthurSens commented Dec 4, 2023

Fixes #1002

I'm adding deprecation notice so backwards compatibility can be kept, but I feel like having 2 strategies to do the same thing can be confusing. 🤔

@ArthurSens ArthurSens force-pushed the labels/annotations branch 2 times, most recently from c9d9e0e to 390e7f7 Compare December 6, 2023 17:42
@ArthurSens ArthurSens changed the base branch from main to release-0.7 December 6, 2023 17:43
@ArthurSens
Copy link
Contributor Author

I've also changed the base branch to release-0.7 here, let me know if you wanted something different :)

Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com>
(cherry picked from commit cacaa79)
@metalmatze metalmatze deleted the branch pyrra-dev:release-0.7 February 21, 2024 00:53
@metalmatze metalmatze closed this Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using Kubernetes labels/annotation as Prometheus alert labels and annotations is limiting
2 participants