Fix invalid PrometheusRule when adding grouping to a ratio indicator #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We are testing a version of Pyrra built from our fork for this pull request and it is able to create SLOs with grouping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ruleshere were being added torule.Groups, even if we have had anErrGroupingUnsupportederror returned by theobjective.GenericRules()function. This results in an empty rule being added to thePrometheusRulespec, which fails validation.I just added an
elsebranch so the rule is not added to the spec if anErrGroupingUnsupportederror has been raised.I think this should fix #976.