Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration tests for 'Need a mechanism to determine build's state (b… #18

Merged
merged 6 commits into from Dec 16, 2022
Merged

Integration tests for 'Need a mechanism to determine build's state (b… #18

merged 6 commits into from Dec 16, 2022

Conversation

karolh2000
Copy link
Member

…ased on the build ID) (#1254)'

@karolh2000 karolh2000 added this to the 0.2.2 milestone Dec 1, 2022
@karolh2000
Copy link
Member Author

This PR depends on https://github.com/karolh2000/pyrsia/tree/karol2000/1254 and cannot be merged before the mentioned branch is merged into pyrsia/main.

@karolh2000 karolh2000 mentioned this pull request Dec 1, 2022
Merged
6 tasks
@ihcomega56 ihcomega56 closed this Dec 15, 2022
@ihcomega56 ihcomega56 deleted the karolh2000/int_tests_for_1254 branch December 15, 2022 23:45
@ihcomega56 ihcomega56 reopened this Dec 15, 2022
@karolh2000
Copy link
Member Author

@ihcomega56 looks good

ihcomega56
ihcomega56 approved these changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@ihcomega56 ihcomega56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Karol and I worked together, and now we both think it can be approved.

dasmanas
dasmanas approved these changes Dec 16, 2022
View reviewed changes
Copy link

@dasmanas dasmanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@karolh2000 karolh2000 merged commit 72c67cf into pyrsia:main Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihcomega56 ihcomega56 ihcomega56 approved these changes

@dasmanas dasmanas dasmanas approved these changes

@fishseabowl fishseabowl Awaiting requested review from fishseabowl

Assignees

@ihcomega56 ihcomega56

Labels
None yet
Projects
Pyrsia Development
Archived in project
Milestone
0.2.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@karolh2000 @ihcomega56 @dasmanas