Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return actual build id when requesting build on another node #1321

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

tiainen
Copy link
Collaborator

@tiainen tiainen commented Nov 23, 2022

Description

Fixes #1313

This PR returns the actual build ID to the Pyrsia CLI when the build command was used and the actual build was triggered on a different Pyrsia node instead of the local Pyrsia node.

Steps to test

Follow the procedure described in Pyrsia demo: build Docker images from source. When triggering a build from source from node B (aka the node that was not authorized) using the pyrsia CLI, it should print a UUID instead of a regular number:

Build request successfully handled. Build with ID 4cffa388-52b1-4f5c-9516-bbdbcfbf49ca has been started.

PR Checklist

Code Contributions

  • I've built the code cargo build --all-targets successfully.
  • I've run the unit tests cargo test --workspace and everything passes.

@tiainen tiainen requested a review from a team as a code owner November 23, 2022 14:44
@tiainen tiainen requested review from erwin1 and fishseabowl and removed request for a team November 23, 2022 14:44
@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Merging #1321 (6eae790) into main (63d098b) will increase coverage by 0.92%.
The diff coverage is 80.76%.

@@            Coverage Diff             @@
##             main    #1321      +/-   ##
==========================================
+ Coverage   47.71%   48.64%   +0.92%     
==========================================
  Files          54       54              
  Lines        2821     2835      +14     
==========================================
+ Hits         1346     1379      +33     
+ Misses       1475     1456      -19     
Impacted Files Coverage Δ
pyrsia_node/src/main.rs 0.00% <0.00%> (ø)
pyrsia_node/src/network/handlers.rs 0.00% <0.00%> (ø)
src/network/build_protocol.rs 84.37% <85.71%> (+38.22%) ⬆️
src/network/client.rs 76.59% <100.00%> (+2.68%) ⬆️
src/network/event_loop.rs 31.04% <100.00%> (+4.03%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tiainen tiainen added this to the 0.2.1 milestone Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Build ID differs if build is requested from the authorized node vs regular/local node
4 participants