Case cache option in POST requests

[foxbunny]

Is there any use case for cache option in POST requests? If not, then I suggest the default value of cache option to depend on method name, where it would be false by default on GET requests, and true for POST. I'll do a PR so you can see what I mean.

[pyrsmk]

I think POST requests can return different responses and they can handle a lot of request types with the _METHOD attribute that is used in some frameworks, as PUT, DELETE and other manual types. Caching POST requests shouldn't affect normal behavior of an application?

[foxbunny]

I don't think it does, but I also think it's unnecessary, and having true as default for POST is reasonable.

POST requests aren't meant to be cached under normal circumstances, and browsers won't cache it, so there's no need for cache-busting. Same applies for all simulated verbs which are using POST behind the scenes with more or less similar semantic in terms of cache-ability.

[pyrsmk]

Ok, then I'm agree with your changes. Just one thing, at line 248, your line should be :

if(cache === null){ cache = method=='POST'; }

Otherwise if cache is false then your condition will override the value.

[foxbunny]

You're rigth. But let's make that:

if (typeof cache == 'undefined' || cache === null){ cache = method=='POST'; }

[foxbunny]

Actually. Hm. No, leave it as it is in my original pull. false == null is never true.

EDIT:

Just tested in most of the browsers I have + NodeJS.

Using double-equals with null will be true only for undefined and null itself.

[pyrsmk]

Yep, I just saw on MDN that null is seen as an object by typeof. But, if cache is undefined, is it considered as null?

[foxbunny]

Here's a console session to prove it works:

false == null
false
null == null # This is what we want
true
undefined == null # And this
true
0 == null
false
'' == null
false
'null' == null
false

[foxbunny]

FYI, CoffeeScript and similar languages almost universally use the == null technique to test if something is undefined or null, so I think it's safe to use. I use it all the time because I use Coffee/LiveScript and it's never lead to weird unexpected behavior.

[pyrsmk]

Interesting! Fine, let's do that PR ^^

[pyrsmk]

And thanks a lot for your help ;)

[foxbunny]

Just scratching my own itch. :)

[pyrsmk]

It seems apache does not support POST requests caching. Then, cache option is now disabled for all requests.