Adbscan fix #120
Merged
Adbscan fix #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darribas
reviewed
Jun 11, 2020
|
Thank you for the review @weikang9009 @darribas! This should now be ready to merge. |
|
Not sure why the additional commits were introduced. Possibly through an erroneous rebase? Still, should not affect the core of the submission on adbscan.py? |
This should pass once #124 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
adbscan(formally) a scikit-learn estimator by making its inheritance from_ClusterMixinandBaseEstimatorexplicit.I don't think this affects anything, but it'd be good to check more than the existing test suite...