Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PERF] List comprehension to array operation in local multivariate Geary #185

Merged
merged 3 commits into from Jul 3, 2021

Conversation

TLouf
Copy link

@TLouf TLouf commented Jul 3, 2021

Partial fix of #181.

Passed testing with nosetests:

............................................SS.S...S.S.S.................................SSS............................
----------------------------------------------------------------------
Ran 120 tests in 19.110s

@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2021

Codecov Report

Merging #185 (d430914) into master (620a881) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #185      +/-   ##
==========================================
- Coverage   81.46%   81.43%   -0.03%     
==========================================
  Files          40       40              
  Lines        4062     4057       -5     
==========================================
- Hits         3309     3304       -5     
  Misses        753      753              
Impacted Files Coverage Δ
esda/geary_local_mv.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 620a881...d430914. Read the comment docs.

@jGaboardi
Copy link
Member

Thanks for this @TLouf!

@jGaboardi jGaboardi merged commit 0d1c574 into pysal:master Jul 3, 2021
@TLouf TLouf deleted the mv-geary-perf branch July 3, 2021 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants