Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI update & redesign #173

Merged
merged 11 commits into from Apr 1, 2022
Merged

CI update & redesign #173

merged 11 commits into from Apr 1, 2022

Conversation

jGaboardi
Copy link
Member

@jGaboardi jGaboardi commented Mar 20, 2022

This PR:

@jGaboardi jGaboardi changed the title blacken giddy repo CI update & redesign Mar 20, 2022
@jGaboardi
Copy link
Member Author

Test on windows keep stalling out for test_directional.py::i::test_rose. Tried without multicore tests, but still stalling.

@weikang9009
Copy link
Member

Test on windows keep stalling out for test_directional.py::i::test_rose. Tried without multicore tests, but still stalling.

Thanks for getting this done @jGaboardi ! It is probably because the tester tries to plot a figure, but I am not sure though as splot was also testing against plotting figures. That being said, since splot is already testing on these plotting functions, I think in giddy we might be safe if not testing again? But of course, if we can resolve the current issue, that would be best.

@jGaboardi
Copy link
Member Author

hey @weikang9009! It seems that splot's continuous integration has been disabled for awhile, so I'll go ahead and get that started. But assuming that splot's test for the Rose plot passes, then must being something hanging up within that function itself. There was a similar problem with spaghetti recently that we fixed with a timeout flag. Maybe @martinfleis might have some insight?

@martinfleis
Copy link
Member

The fact that it is testing a plot should not cause the issue. Not sure what does though.

@sjsrey
Copy link
Member

sjsrey commented Apr 1, 2022

Going to merge as this improves things quite a bit. Can then work on the failing case.

@sjsrey sjsrey merged commit 564ec42 into pysal:master Apr 1, 2022
@jGaboardi jGaboardi deleted the blacken_repo branch April 1, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants