Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dev branches; test shapely dev #176

Merged
merged 6 commits into from Nov 3, 2022

Conversation

jGaboardi
Copy link
Member

This PR:

xref pysal/splot#161

@martinfleis
Copy link
Member

It seems that installation of dev versions from git downgraded shapely to 1.8.5.

@jGaboardi
Copy link
Member Author

It seems that installation of dev versions from git downgraded shapely to 1.8.5.

good catch

@jGaboardi
Copy link
Member Author

Having trouble figuring out where the shapely<2,>=1.7 requirement is actually coming from. Will dig more into this later. Or do we think simply reinstalling shapely>=2.0b1 after the downgrade would suit our needs for testing?

@martinfleis
Copy link
Member

That is coming from geopandas 0.12. We fixed it in 0.12.1 but that somehow never made it to conda-forge. I'll update the feedstock now.

@martinfleis
Copy link
Member

One thing we should do is to call conda list once everything is installed, not before pip install as the action does itself. Similarly to what we have in geopandas here https://github.com/geopandas/geopandas/actions/runs/3368984312/jobs/5588143381#step:4:1 . It would be much easier to pick this up.

conda-forge has been updated. Give it a bit to propagate to servers and we can try again.

@jGaboardi
Copy link
Member Author

Did that and trying for Python 3.11 just for fun.

@jGaboardi
Copy link
Member Author

@weikang9009 is pretty busy with her new responsibilities. Do we want to wait for a review from @sjsrey or go ahead and merge?

@martinfleis martinfleis merged commit faa5c8c into pysal:master Nov 3, 2022
@jGaboardi jGaboardi deleted the update_mapclassify_branch branch November 3, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants