Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code 2to3 #34

Merged
merged 3 commits into from May 17, 2018
Merged

code 2to3 #34

merged 3 commits into from May 17, 2018

Conversation

weikang9009
Copy link
Member

No description provided.

@weikang9009 weikang9009 requested a review from sjsrey May 15, 2018 23:49
Copy link
Member

@sjsrey sjsrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Should we merge, and then you can add the new classifiers as new discretization methods later?

@weikang9009
Copy link
Member Author

Sounds good!

@weikang9009
Copy link
Member Author

I am thinking of doing a release now so that users can utilize categorical spatial Markov. Any objections?

@weikang9009 weikang9009 requested a review from ljwolf May 15, 2018 23:57
@sjsrey
Copy link
Member

sjsrey commented May 16, 2018

Sounds good. We need to start having release numbers and a changelog. The convention we talked about for the pysal project for release numbers is something like
Major.Feature.Bug

So, for example, the first release of giddy should have been 1.0.0

Then if we say added a feature and relased that one would be 1.1.0

Then if we found a bug in that relase and fixed it: 1.1.1

And a new set of features in the same api: 1.2.0
and so on.

@weikang9009
Copy link
Member Author

Sounds very reasonable!

@weikang9009 weikang9009 merged commit 6637790 into pysal:master May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants