This repository has been archived by the owner on Jul 19, 2018. It is now read-only.
GWR speed-up 1 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Ziqi, These enhancements looks promising. Tests are passing so I'll merge this in. I think we can make a few more changes to minimize the amount of code that is replicated throughout the codebase in order to achieve a "separate" mechanism to compute diagnostics for bandwidth search. |
This was referenced Jan 18, 2018
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a
finalparameter inGWR.fit()function.final=Falseindicates in optimal bandwidth searching process.final=Trueindicates we are using optimal bandwidth found to fit the GWR model. The running time is expected to decrease 2x to 5x depending on the data.