Weights constructor behaving unexpectedly with dataframe IDs

[darribas]

Attached full (reproducible, zipped) notebook, but the gist of it is:

From the docstring:

idVariable  : string
                    the name of the column to use as IDs. If nothing is
                    provided, the dataframe index is used

Shoudn't [5] output be the same as [4]?

weights_ids.zip

[sjsrey]

This is not working as documented.

[jGaboardi]

In the case of [5] the conditionals in line 325, line 335, line 337 are False so line 339(below) is running with the idVariable, ids, and id_order arguments still being None.

w = cls.from_iterable(df[geom_col].tolist(), ids=ids, id_order=id_order, **kwargs)

Should the documentation change or the functionality?

[sjsrey]

I'm working on changing the functionality (in libpysal) so we get something like:

[jGaboardi]

#184

[github-actions]

Stale issue message