Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

W.plot method is generating long list of deprecation warnings #464

Closed
sjsrey opened this issue Apr 13, 2022 · 0 comments · Fixed by #465
Closed

W.plot method is generating long list of deprecation warnings #464

sjsrey opened this issue Apr 13, 2022 · 0 comments · Fixed by #465
Assignees
@martinfleis
Labels
rough edge Something that's not a bug, but that gets in the way of "it just works."

Comments

@sjsrey
Copy link
Member

sjsrey commented Apr 13, 2022

Grabbing the centroids needs to be refactored to reflect the deprecation:

/Users/serge/miniconda3/envs/pysal-iale2022/lib/python3.9/site-packages/libpysal/weights/weights.py:1296: FutureWarning: Passing a dict as an indexer is deprecated and will raise in a future version. Use a list instead.
  centroids = gdf.loc[neighbors].centroid.apply(lambda p: (p.x, p.y))
@sjsrey sjsrey added the rough edge Something that's not a bug, but that gets in the way of "it just works." label Apr 13, 2022
@martinfleis martinfleis self-assigned this Apr 13, 2022
@martinfleis martinfleis mentioned this issue Apr 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martinfleis martinfleis

Labels
rough edge Something that's not a bug, but that gets in the way of "it just works."
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

vectorize centroid in W.plot martinfleis/libpysal
2 participants
@sjsrey @martinfleis