vectorize centroid in W.plot #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Btw, I am not sure if this is actually tested... |
Codecov Report
@@ Coverage Diff @@
## main #465 +/- ##
=======================================
+ Coverage 84.0% 84.1% +0.2%
=======================================
Files 128 128
Lines 15053 15072 +19
=======================================
+ Hits 12642 12681 +39
+ Misses 2411 2391 -20
|
|
It's not iirc... |
okay, I'll add a test |
sjsrey
approved these changes
Jun 12, 2022
spolloni
reviewed
Jul 26, 2022
|
This should be ready now. |
|
this got forgotten but also resolves some warnings. those are not visible in CI because it was not tested until now :) |
jGaboardi
approved these changes
Oct 21, 2023
|
|
🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #464
Avoiding
applyaltogether here. This will use vectorized pygeos implementation.