Testing matrix #363
Merged
Testing matrix #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you considered/tried adding py3.9? May be worth including it. |
@martinfleis Great point. Let's make sure these all pass first then push forward with that. Also, feel free to push directly to PR if you have ideas, etc. |
|
@martinfleis Looks like the environment solver fails for 3.9 even on Ubuntu. Might we have to leave off 3.9 for the time being? |
|
@jGaboardi Yep, it is apparently not time yet. I was adding it to geopandas where it works, but here we have a bit more complex environment. |
martinfleis
approved these changes
Nov 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a similar testing schema to that found in
spaghettiwhere testing for the Python 3.6 environment is excluded on Windows. This exclusion gets tests back to green and is an intermediary solution to dropping support for Python 3.6 altogether.xref: pysal/spaghetti#545, pysal/spaghetti#552, pysal/esda#152, and gitter discussion