Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed index2da causing inverted output #400

Merged
merged 2 commits into from Jun 13, 2021
Merged

Fixed index2da causing inverted output #400

merged 2 commits into from Jun 13, 2021

Conversation

MgeeeeK
Copy link
Contributor

@MgeeeeK MgeeeeK commented Apr 13, 2021

@MgeeeeK
Copy link
Contributor Author

MgeeeeK commented Apr 13, 2021

@sjsrey @darribas I think its fixed now

@sjsrey
Copy link
Member

sjsrey commented Apr 16, 2021

@sjsrey @darribas I think its fixed now

should we pin to a version of xarray before the breakage, and then change when they release the new version that fixes this?

@MgeeeeK
Copy link
Contributor Author

MgeeeeK commented Apr 16, 2021

@sjsrey @darribas I think its fixed now

should we pin to a version of xarray before the breakage, and then change when they release the new version that fixes this?

Here I was referring to the error that index2da was raising in #399.
Earlier, due to a bug related to MultiIndex in the xarray, I had to sort the data to align it with the indices (the bug was fixed in the latest release v0.17.0 (24 Feb 2021) and therefore, there is no need for sorting)

I can also add support for the previous versions cos this will fail if the users are using xarray<0.17.0 package.

@sjsrey sjsrey merged commit 06b57db into pysal:master Jun 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Raster weights w2da failing on 3.6
2 participants