fix piping of constructors to Graph after #548 #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinfleis
commented
Aug 25, 2023
| @@ -112,6 +112,9 @@ def test_correctness_voronoi_clipping(): | |||
| numpy.testing.assert_array_equal(G_alpha.adjacency.index, alpha_known[0]) | |||
| numpy.testing.assert_array_equal(G_alpha.adjacency.neighbor, alpha_known[1]) | |||
|
|
|||
|
|
|||
| # TODO: this now fails, probably never worked. | |||
| @pytest.mark.xfail | |||
There was a problem hiding this comment.
This was a new test added in #548 which fails now. I may look into it later but just marked it with todo now.
martinfleis
changed the title
martinfleis
commented
Aug 25, 2023
| if kernel is None and bandwidth is None: | ||
| numpy.testing.assert_array_equal(weights, numpy.ones_like(heads)) | ||
| assert set(zip(heads, tails)) == set(zip(tails, heads)), "all triangulations should be symmetric, this is not" | ||
| # @parametrize_constructors |
There was a problem hiding this comment.
I've commented this out for now because this results in a huge number of combinations that take ages to process. I honestly don't think we need to test all those combinations anyway.
Codecov Report
@@ Coverage Diff @@
## geographs #553 +/- ##
===========================================
- Coverage 81.1% 81.0% -0.1%
===========================================
Files 127 127
Lines 14560 14704 +144
===========================================
+ Hits 11801 11910 +109
- Misses 2759 2794 +35
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an intermediate step ensuring that all the piping to the constructors works again after it was broken by changes in #548.
I'll likely self-merge this and continue with the sorting stuff. That may include further changes to data structures returned by individual functions, so don't take the changes here as something we should settle on.