Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: avoid most of the warnings coming from dev CI #591

Merged
merged 6 commits into from Oct 21, 2023

Conversation

martinfleis
Copy link
Member

@martinfleis martinfleis commented Oct 21, 2023

Some future-proofing, a lot of silencing. Got it down from 1200+ to 5, out of which 4 will be solved in upstream (apache/arrow#38374) and one seems to be coming from scipy.sparse internals, so there's not a lot we can do apart from silencing but I'd give it some time.

Closes #582

Copy link
Member

@jGaboardi jGaboardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Great work.

libpysal/weights/util.py Outdated Show resolved Hide resolved
@jGaboardi jGaboardi added rough edge Something that's not a bug, but that gets in the way of "it just works." tests labels Oct 21, 2023
@jGaboardi
Copy link
Member

Approved too soon... Seeing failurespandas._config.config.OptionError: No such keys(s): 'future.no_silent_downcasting'

@martinfleis
Copy link
Member Author

Because the way pandas is deprecating the downcast keyword is not very friendly. You can either do that option, but that is available only on main or filter warnings. Given the behaviour in our case does not change, I will just filter them so they don't bubble up to a user.

@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

Merging #591 (781d8fa) into main (5d09bc6) will increase coverage by 0.2%.
Report is 1 commits behind head on main.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #591     +/-   ##
=======================================
+ Coverage   84.0%   84.2%   +0.2%     
=======================================
  Files        128     128             
  Lines      15053   15080     +27     
=======================================
+ Hits       12642   12698     +56     
+ Misses      2411    2382     -29     
Files Coverage Δ
libpysal/cg/alpha_shapes.py 84.4% <100.0%> (+0.2%) ⬆️
libpysal/cg/tests/test_ashapes.py 97.4% <100.0%> (+0.2%) ⬆️
libpysal/graph/_utils.py 88.9% <100.0%> (+0.5%) ⬆️
libpysal/graph/base.py 96.4% <ø> (ø)
libpysal/io/iohandlers/pyDbfIO.py 78.0% <ø> (ø)
libpysal/io/iohandlers/tests/test_gwt.py 97.6% <100.0%> (+0.1%) ⬆️
libpysal/weights/tests/test_util.py 98.3% <100.0%> (ø)
libpysal/weights/util.py 78.5% <100.0%> (+1.5%) ⬆️

... and 2 files with indirect coverage changes

@martinfleis martinfleis merged commit 9289ba4 into pysal:main Oct 21, 2023
9 of 10 checks passed
@martinfleis martinfleis deleted the bulk branch October 21, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rough edge Something that's not a bug, but that gets in the way of "it just works." tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GeoPandas FutureWarning in fuzzy_contiguity
2 participants