Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint & format graph/tests/*.py #619

Merged
merged 5 commits into from Nov 1, 2023

Conversation

jGaboardi
Copy link
Member

xref #589

This PR formats and lints libpysal/graph/tests/*.py

@jGaboardi jGaboardi self-assigned this Oct 31, 2023
@jGaboardi jGaboardi marked this pull request as draft October 31, 2023 22:22
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #619 (59c8d7a) into main (b027196) will decrease coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #619     +/-   ##
=======================================
- Coverage   84.4%   84.4%   -0.0%     
=======================================
  Files        139     139             
  Lines      14881   14862     -19     
=======================================
- Hits       12559   12540     -19     
  Misses      2322    2322             
Files Coverage Δ
libpysal/graph/_utils.py 89.3% <100.0%> (ø)
libpysal/graph/tests/test_base.py 100.0% <100.0%> (ø)
libpysal/graph/tests/test_builders.py 100.0% <100.0%> (ø)
libpysal/graph/tests/test_contiguity.py 100.0% <100.0%> (ø)
libpysal/graph/tests/test_kernel.py 100.0% <100.0%> (ø)
libpysal/graph/tests/test_plotting.py 100.0% <ø> (ø)
libpysal/graph/tests/test_set_ops.py 100.0% <100.0%> (ø)
libpysal/graph/tests/test_spatial_lag.py 100.0% <100.0%> (ø)
libpysal/graph/tests/test_triangulation.py 84.2% <100.0%> (-0.1%) ⬇️
libpysal/graph/tests/test_utils.py 98.8% <100.0%> (ø)

@jGaboardi
Copy link
Member Author

@martinfleis This one's a bit bigger diff than ideal, but the vast majority are upper->lowercase variable renaming in tests.

Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one note. Thanks!

libpysal/graph/tests/test_set_ops.py Outdated Show resolved Hide resolved
@jGaboardi jGaboardi marked this pull request as ready for review November 1, 2023 14:09
@martinfleis martinfleis merged commit 3349d10 into pysal:main Nov 1, 2023
9 of 10 checks passed
@jGaboardi jGaboardi deleted the lint_format_graph_tests branch November 1, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants