Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMPAT: compatibility with pandas 3 #692

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

martinfleis
Copy link
Member

pandas no longer returns names of MultiIndex as a list but as a tuple. Making our check compatible.

This will need to be released before pandas 3 which is scheduled for April. Otherwise, graph module will be unusable with pandas 3.

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.9%. Comparing base (018f1e2) to head (d6142d7).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #692     +/-   ##
=======================================
+ Coverage   84.7%   84.9%   +0.2%     
=======================================
  Files        141     141             
  Lines      15200   15199      -1     
=======================================
+ Hits       12880   12910     +30     
+ Misses      2320    2289     -31     
Files Coverage Δ
libpysal/graph/base.py 97.9% <100.0%> (ø)

... and 11 files with indirect coverage changes

@jGaboardi jGaboardi merged commit caeaa82 into pysal:main Mar 9, 2024
11 checks passed
@martinfleis martinfleis deleted the pandas_compat branch March 9, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants