Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Add examples to build_distance_band #705

Merged
merged 8 commits into from
Apr 14, 2024
Merged

Conversation

novotny-marek
Copy link
Contributor

Add docstring examples to build_distance_band

Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions in the code.

libpysal/graph/base.py Outdated Show resolved Hide resolved
libpysal/graph/base.py Outdated Show resolved Hide resolved
libpysal/graph/base.py Outdated Show resolved Hide resolved
libpysal/graph/base.py Show resolved Hide resolved
libpysal/graph/base.py Outdated Show resolved Hide resolved
@martinfleis
Copy link
Member

Also, can you run ruff format libpysal to make the linter happy? You have trailing whitespaces in there.

Copy link

codecov bot commented Apr 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.0%. Comparing base (bcabdbc) to head (5016b3f).
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #705     +/-   ##
=======================================
- Coverage   85.0%   85.0%   -0.0%     
=======================================
  Files        141     141             
  Lines      15203   15204      +1     
=======================================
- Hits       12924   12923      -1     
- Misses      2279    2281      +2     
Files Coverage Δ
libpysal/graph/base.py 97.9% <100.0%> (ø)

libpysal/graph/base.py Outdated Show resolved Hide resolved
novotny-marek and others added 2 commits April 14, 2024 19:04
Co-authored-by: Martin Fleischmann <martin@martinfleischmann.net>
Co-authored-by: Martin Fleischmann <martin@martinfleischmann.net>
@martinfleis
Copy link
Member

martinfleis commented Apr 14, 2024

pre-commit.ci autofix

libpysal/graph/base.py Outdated Show resolved Hide resolved
@martinfleis martinfleis merged commit 31c4d83 into pysal:main Apr 14, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants