Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMPAT: remove typing from Graph.describe #719

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

martinfleis
Copy link
Member

We don't use types anywhere in the module and these were also using deprecated numpy dtype. Removing for consistency.

Fixes pysal/mapclassify#214

Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.1%. Comparing base (bcabdbc) to head (c14f583).
Report is 21 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #719     +/-   ##
=======================================
+ Coverage   85.0%   85.1%   +0.1%     
=======================================
  Files        141     145      +4     
  Lines      15203   15567    +364     
=======================================
+ Hits       12924   13252    +328     
- Misses      2279    2315     +36     
Files Coverage Δ
libpysal/graph/base.py 96.8% <ø> (-1.1%) ⬇️

... and 6 files with indirect coverage changes

@jGaboardi jGaboardi added the rough edge Something that's not a bug, but that gets in the way of "it just works." label Jun 10, 2024
@jGaboardi jGaboardi merged commit 56d23f1 into pysal:main Jun 10, 2024
11 checks passed
@martinfleis martinfleis deleted the np-typing branch June 10, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rough edge Something that's not a bug, but that gets in the way of "it just works."
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] failing dev from libpysal.graph --> numpy.float_
2 participants