Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove function regime_weights #96

Merged
merged 1 commit into from Aug 11, 2018
Merged

remove function regime_weights #96

merged 1 commit into from Aug 11, 2018

Conversation

weikang9009
Copy link
Member

Resolve #94

sjsrey
sjsrey requested changes Aug 11, 2018
View reviewed changes
Copy link
Member

@sjsrey sjsrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be changes in the tests (integration as well as doctests) to reflect the removal?

@weikang9009
Copy link
Member Author

weikang9009 commented Aug 11, 2018 •
edited

There is not a unittest for function regime_weights , probably because it is basically calling the other function block_weights under the hood.

@sjsrey
Copy link
Member

sjsrey commented Aug 11, 2018

@weikang9009 is right on the testing, just wanted to check if we were missing deltas for the tests. we are not so I'm good with the changes.

@weikang9009 weikang9009 merged commit e66ca8b into pysal:master Aug 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjsrey sjsrey sjsrey approved these changes

@ljwolf ljwolf Awaiting requested review from ljwolf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@weikang9009 @sjsrey