Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove spaces from title of classifier table string #145

Closed
jGaboardi opened this issue Nov 6, 2022 · 2 comments · Fixed by #153
Closed

remove spaces from title of classifier table string #145

jGaboardi opened this issue Nov 6, 2022 · 2 comments · Fixed by #153
Assignees
@jGaboardi
Labels
rough edge

Comments

@jGaboardi
Copy link
Member

The spaces added to the title of classifier table strings are causing linting to fail when updating docstring. I can see no reason no to get rid of those extra spaces (tests are passing locally without the spaces in the string repr).

It's a minor thing, but I vote for removing.
@jGaboardi jGaboardi self-assigned this Nov 6, 2022
sjsrey pushed a commit to sjsrey/mapclassify that referenced this issue Nov 7, 2022
ENH: addressing pysal#145
cc4bfd0
@sjsrey
Copy link
Member

sjsrey commented Nov 7, 2022

We need the three spaces for table alignment. Would #152 take care of the linter issue?

@jGaboardi
Copy link
Member Author

I gave a more clear explanation here.

jGaboardi added a commit to jGaboardi/mapclassify that referenced this issue Nov 8, 2022
@jGaboardi
resolves pysal#145
f146623
@jGaboardi jGaboardi mentioned this issue Nov 8, 2022
Merged
jGaboardi pushed a commit that referenced this issue Nov 8, 2022
@sjsrey
ENH: addressing #145 (#152)
bd11fd0 
* ENH: addressing #145

* Use f-strings for table format

Co-authored-by: Serge Rey <serge@pop-os.localdomain>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jGaboardi jGaboardi

Labels
rough edge
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove spaces after table string title jGaboardi/mapclassify
2 participants
@sjsrey @jGaboardi