Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add anchor option to StdMean #176

Merged
merged 19 commits into from Jun 9, 2023
Merged

Add anchor option to StdMean #176

merged 19 commits into from Jun 9, 2023

Conversation

sjsrey
Copy link
Member

@sjsrey sjsrey commented Mar 29, 2023

Creates bins such that lowest bound is min(y), maximum bound is max(y) and each intermediate bin width is set to std(y).
This mimics opengeoda.

@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #176 (44b82f2) into main (89e5843) will decrease coverage by 0.2%.
The diff coverage is 100.0%.

❗ Current head 44b82f2 differs from pull request most recent head 911814c. Consider uploading reports for the commit 911814c to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #176     +/-   ##
=======================================
- Coverage   88.8%   88.6%   -0.2%     
=======================================
  Files          8       8             
  Lines       1070    1075      +5     
=======================================
+ Hits         950     952      +2     
- Misses       120     123      +3     
Impacted Files Coverage Δ
mapclassify/_classify_API.py 96.6% <100.0%> (ø)
mapclassify/classifiers.py 88.0% <100.0%> (-0.3%) ⬇️

Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor note on docstring. Once that is fixed, lgtm.

mapclassify/classifiers.py Outdated Show resolved Hide resolved
sjsrey and others added 6 commits April 6, 2023 08:16
Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 4 to 5.
- [Release notes](https://github.com/peter-evans/create-pull-request/releases)
- [Commits](peter-evans/create-pull-request@v4...v5)

---
updated-dependencies:
- dependency-name: peter-evans/create-pull-request
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@sjsrey
Copy link
Member Author

sjsrey commented Jun 9, 2023

I'm not clear on why the linter is failing on the ci as locally it is passing:

image

@jGaboardi any clues?

@sjsrey
Copy link
Member Author

sjsrey commented Jun 9, 2023

Fixed it. @jGaboardi please ignore previous request for help.

@sjsrey sjsrey merged commit e778683 into pysal:main Jun 9, 2023
13 checks passed
@sjsrey sjsrey deleted the std branch June 9, 2023 22:08
@jGaboardi
Copy link
Member

Fixed it. @jGaboardi please ignore previous request for help.

Sorry for the late response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants