Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMPAT: make greedy compatible with future #210

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

martinfleis
Copy link
Member

Closes #209

I have no clue which package causes this, probably some weird interaction between multiple nightly wheels. No clue, I really tried to debug it. Gave up and opted for an explicit check that the result is indeed greedy instead. We don't care about the counts, we only care if the colouring ensures two adjacent polygons do not share the colour.

Also updated use_index usage to silence the warnings.

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.4%. Comparing base (17ae858) to head (28b851e).

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #210   +/-   ##
=====================================
  Coverage   89.4%   89.4%           
=====================================
  Files          8       8           
  Lines       1088    1088           
=====================================
  Hits         973     973           
  Misses       115     115           
Files Coverage Δ
mapclassify/greedy.py 100.0% <100.0%> (ø)

@jGaboardi jGaboardi added the CI label Apr 3, 2024
@martinfleis martinfleis merged commit d9c60ce into pysal:main Apr 3, 2024
15 checks passed
@martinfleis martinfleis deleted the greedy-compat branch April 3, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

311-dev CI failures [2024-04-01]
2 participants