Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: doctest only on ubuntu latest #219

Merged
merged 4 commits into from
Jun 26, 2024
Merged

Conversation

martinfleis
Copy link
Member

Following the spaghetti model but being a bit more restrictive on when it runs.

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.4%. Comparing base (b79bb10) to head (ca77947).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #219     +/-   ##
=======================================
- Coverage   89.4%   87.4%   -2.0%     
=======================================
  Files          8       8             
  Lines       1088    1088             
=======================================
- Hits         973     951     -22     
- Misses       115     137     +22     

see 1 file with indirect coverage changes

@jGaboardi
Copy link
Member

You'll need to add pytest-doctestplus to environement / dependencies.

@jGaboardi jGaboardi added docs github_actions Pull requests that update GitHub Actions code labels Jun 26, 2024
Co-authored-by: James Gaboardi <jgaboardi@gmail.com>
@jGaboardi jGaboardi merged commit e0e4cfa into pysal:main Jun 26, 2024
15 checks passed
@martinfleis martinfleis deleted the doctest branch June 26, 2024 20:55
knaaptime pushed a commit to knaaptime/mapclassify that referenced this pull request Jul 2, 2024
* CI: doctest only on ubuntu latest

* try including coverage

* doctestplus

* Apply suggestions from code review

Co-authored-by: James Gaboardi <jgaboardi@gmail.com>

---------

Co-authored-by: James Gaboardi <jgaboardi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants