Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bool variables and singular matrix error #42

Closed
jy03189211 opened this issue Oct 29, 2018 · 2 comments
Closed

bool variables and singular matrix error #42

jy03189211 opened this issue Oct 29, 2018 · 2 comments
Assignees

Comments

@jy03189211
Copy link

jy03189211 commented Oct 29, 2018

Currently not supporting the bool variable or any variable contains 0 when calculating the bandwidth or doing matrix inverting, it throws 'LinAlgError: Singular matrix'

while most of the R package does.
Some suggest from https://stackoverflow.com/questions/47710110/linalgerror-singular-matrix

Do you have a plan to add support for bool or categorical variable value with 0

@ljwolf
Copy link
Member

ljwolf commented Oct 30, 2018

I think we should & we can. The commenter is correct in that we should use solve instead of inv nearly always. I also see this as a recapitulation of this older bug

Thanks for raising it, and we'll address it.

@TaylorOshan
Copy link
Collaborator

Agreed on using solve, but that older bug was actually a superficial divide-by-zero that has since been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants