-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
progress bar in GWRResults spatial_variability #91
Comments
Good idea! PR would be very welcome. Only difference in those two examples is that I believe n_iters here is endogenously set based on the data, whereas it is (or rather can be) exogenously set by the user (default is 200 IIRC). |
pareyesv
added a commit
to pareyesv/mgwr
that referenced
this issue
Apr 27, 2021
* add progress bar in spatial_variability GWRResults and MGWRResults Close progress bar in GWRResults spatial_variability pysal#91
This is how it looks like (example from GWR_MGWR_example notebook) |
@TaylorOshan thanks for your time and help! 👏 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Considering spatial_variability is very computationally demanding, it'd be nice to add a progress bar (
tqdm
) to the for-loop here:mgwr/mgwr/gwr.py
Lines 1217 to 1225 in 5e7fa3f
tqdm
is already used heremgwr/mgwr/search.py
Lines 202 to 209 in 5e7fa3f
so I guess the same code should work:
Let me know what you think. I can do the PR (If this is the case, I'd need ideas for the description text:
desc="Testing"
?)The text was updated successfully, but these errors were encountered: